Skip to content

Remove unused variable from images action#7371

Merged
kzys merged 1 commit intocontainerd:mainfrom
estesp:remove-unused
Sep 6, 2022
Merged

Remove unused variable from images action#7371
kzys merged 1 commit intocontainerd:mainfrom
estesp:remove-unused

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Sep 6, 2022

Ran actionlint against all our actions and it found this variable that
is based on a non-existent property (there is no matrix definition in
this action yaml). The variable is also unused so simply removing it.

Signed-off-by: Phil Estes [email protected]

Ran actionlint against all our actions and it found this variable that
is based on a non-existent property (there is no matrix definition in
this action yaml). The variable is also unused so simply removing it.

Signed-off-by: Phil Estes <[email protected]>
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Sep 6, 2022

🤔️

=== FAIL: metadata TestImagesCreateUpdateDelete/ReplaceAnnotation (0.02s)
253
images_test.go:530: timestamp for updatedat not after createdat: 2022-09-06 14:59:39.0596031 +0000 UTC <= 2022-09-06 14:59:39.0596031 +0000 UTC
254
--- FAIL: TestImagesCreateUpdateDelete/ReplaceAnnotation (0.02s)

@kzys
Copy link
Copy Markdown
Member

kzys commented Sep 6, 2022

@fuweid On Windows? Then it may be similar to #7350.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

git blame shows it was added in 407d606, and not used at the time either, so looks like a copy/pasta.

@kzys kzys merged commit db28354 into containerd:main Sep 6, 2022
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Sep 6, 2022

@fuweid On Windows? Then it may be similar to #7350.

Yes. It is odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants