Fix missing close#7370
Conversation
|
Hi @wzshiming. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Your PR branch is 200+ commits behind upstream |
Signed-off-by: Shiming Zhang <[email protected]>
4c1155b to
6ce0f6a
Compare
|
@estesp Thank you, updated. |
kzys
left a comment
There was a problem hiding this comment.
How about adding defer w.Close() after calling OpenWriter()?
@kzys the content/local store might return the error from Close. If we use defer here, we need to update the returned error value if necessary. Since there are not too much if branch, the change is good 😊 |
Signed-off-by: Shiming Zhang [email protected]