Skip to content

Fix missing close#7370

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
wzshiming:fix/missing-close
Sep 7, 2022
Merged

Fix missing close#7370
dmcgowan merged 1 commit intocontainerd:mainfrom
wzshiming:fix/missing-close

Conversation

@wzshiming
Copy link
Copy Markdown
Contributor

Signed-off-by: Shiming Zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @wzshiming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 6, 2022

Your PR branch is 200+ commits behind upstream main; the CI configuration for the CircleCI vagrant runs is out of date and can't run properly until you rebase your branch

Signed-off-by: Shiming Zhang <[email protected]>
@wzshiming
Copy link
Copy Markdown
Contributor Author

@estesp Thank you, updated.

Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding defer w.Close() after calling OpenWriter()?

@dmcgowan dmcgowan merged commit dbd3c8c into containerd:main Sep 7, 2022
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Sep 7, 2022

How about adding defer w.Close() after calling OpenWriter()?

@kzys the content/local store might return the error from Close. If we use defer here, we need to update the returned error value if necessary. Since there are not too much if branch, the change is good 😊

@wzshiming wzshiming deleted the fix/missing-close branch November 3, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants