integration: TestUpdateContainerResources_MemoryLimit: remove TODO comment#7367
Merged
kzys merged 1 commit intocontainerd:mainfrom Sep 6, 2022
Merged
integration: TestUpdateContainerResources_MemoryLimit: remove TODO comment#7367kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
…mment This comment was added in 09a0c94 when the Windows integration tests were enabled. The PR (microsoft/hcsshim#931) was merged, and part of hcsshim v0.9.0, and support for resource limits on Windows was added in 2bc77b8, so it looks like this comment is no longer current. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
/cc @claudiubelu @katiewasnothere @dcantah ptal; I stumbled upon this comment while looking for uses of hccsshim, and I think it was outdated, but perhaps there was still something left to do |
dcantah
approved these changes
Sep 5, 2022
Member
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Not sure if there was more to do for this comment specifically (other than adding a similar test) but the functionality is there #5187 so LGTM. I'll leave the final say to @katiewasnothere and @claudiubelu though. Maybe we should make an issue to add a similar set of tests for windows to track this better.
It looks like there is a test already that should be at least using the functionality to my surprise
containerd/integration/truncindex_test.go
Line 122 in edd59aa
kzys
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment was added in 09a0c94 (#5163) when the Windows integration tests were enabled. The PR (microsoft/hcsshim#931) was merged, and part of hcsshim v0.9.0, and support for resource limits on Windows was added in 2bc77b8 (#5778), so it looks like this comment is no longer current.