Skip to content

feature: upgrade registry.k8s.io/pause version#7359

Merged
fuweid merged 1 commit intocontainerd:mainfrom
lengrongfu:feat_upgrade_pause_version
Sep 6, 2022
Merged

feature: upgrade registry.k8s.io/pause version#7359
fuweid merged 1 commit intocontainerd:mainfrom
lengrongfu:feat_upgrade_pause_version

Conversation

@lengrongfu
Copy link
Copy Markdown
Contributor

@lengrongfu lengrongfu commented Sep 2, 2022

Signed-off-by: rongfu.leng [email protected]

issue: #7358

@k8s-ci-robot
Copy link
Copy Markdown

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 2, 2022

/ok-to-test

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 2, 2022

Can you also update the test image ref in ./integration/images/image_list.go? Thanks!

@lengrongfu
Copy link
Copy Markdown
Contributor Author

Can you also update the test image ref in ./integration/images/image_list.go? Thank

yes

@lengrongfu lengrongfu force-pushed the feat_upgrade_pause_version branch from 2f3f401 to 399bd5f Compare September 3, 2022 02:23
@lengrongfu lengrongfu changed the title feat: upgrade registry.k8s.io/pause version feature: upgrade registry.k8s.io/pause version Sep 3, 2022
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please to make the signoff readable? It is hard to tell the last name from lengrongfu. Thanks

@lengrongfu
Copy link
Copy Markdown
Contributor Author

lengrongfu commented Sep 6, 2022

Would you please to make the signoff readable? It is hard to tell the last name from lengrongfu. Thanks

@fuweid Thanks for your reminder, it has been modified to rongfu.leng.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Sep 6, 2022

Would you please to make the signoff readable? It is hard to tell the last name from lengrongfu. Thanks

@fuweid Thanks for your reminder, it has been modified to rongfu.leng.

@lengrongfu would you please use git commit --amend and repush it? Thanks!

@lengrongfu lengrongfu force-pushed the feat_upgrade_pause_version branch from 399bd5f to ae505e2 Compare September 6, 2022 05:59
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Sep 6, 2022

@lengrongfu there are two lines about your sign-off. You need to delete the first line~

@lengrongfu lengrongfu force-pushed the feat_upgrade_pause_version branch from ae505e2 to 3c0e6c4 Compare September 6, 2022 08:00
@fuweid fuweid merged commit 851bfe8 into containerd:main Sep 6, 2022
@lengrongfu lengrongfu deleted the feat_upgrade_pause_version branch September 6, 2022 14:22
@fuweid fuweid linked an issue Sep 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade registry.k8s.io/pause version

6 participants