Merged
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
log-windows
branch
5 times, most recently
from
780b111 to
f17cdbc
Compare
jterry75
approved these changes
Aug 31, 2022
kzys
force-pushed
the
log-windows
branch
2 times, most recently
from
35ae525 to
f73ad60
Compare
Member
|
Hmm, I'd thought binary logging worked on windows.. @anmaxvl any thoughts? |
Contributor
kzys
force-pushed
the
log-windows
branch
2 times, most recently
from
9a3356c to
1b4b6c3
Compare
kzys
force-pushed
the
log-windows
branch
3 times, most recently
from
19d3630 to
9e2e878
Compare
kzys
force-pushed
the
log-windows
branch
3 times, most recently
from
be7c7b2 to
450343e
Compare
Checking / is not the right way to distinguish an absolute path in Windows. Fixes containerd#5786. Signed-off-by: Kazuyoshi Kato <[email protected]>
Member
Author
anmaxvl
approved these changes
Sep 21, 2022
dcantah
approved these changes
Sep 21, 2022
mxpv
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking / is not the right way to distinguish an absolute path in
Windows.
Fixes #5786.
Signed-off-by: Kazuyoshi Kato [email protected]