Skip to content

delete redundent import alias and and type conversion#7345

Merged
estesp merged 1 commit intocontainerd:mainfrom
zouyee:red
Sep 1, 2022
Merged

delete redundent import alias and and type conversion#7345
estesp merged 1 commit intocontainerd:mainfrom
zouyee:red

Conversation

@zouyee
Copy link
Copy Markdown
Contributor

@zouyee zouyee commented Aug 30, 2022

Signed-off-by: zounengren [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 30, 2022

Hi @zouyee. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thaJeztah
thaJeztah reviewed Aug 30, 2022
View reviewed changes
Comment thread cmd/containerd/command/main.go Outdated
samuelkarp
samuelkarp reviewed Aug 31, 2022
View reviewed changes
Comment thread cmd/containerd/command/main.go Outdated
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 31, 2022

Before I forget to ask; could you also squash the commit? Let me know if you need help doing so; thanks!

@zouyee zouyee requested review from samuelkarp and thaJeztah and removed request for samuelkarp and thaJeztah August 31, 2022 23:08
estesp
estesp approved these changes Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thaJeztah
thaJeztah approved these changes Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thank you!

@estesp estesp merged commit 3d7a93f into containerd:main Sep 1, 2022
@zouyee zouyee deleted the red branch September 1, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zouyee @k8s-ci-robot @thaJeztah @samuelkarp @estesp