Skip to content

chore: matching the casing of other flags for ctr's pull command#7341

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
my-git9:imagepull2
Sep 10, 2022
Merged

chore: matching the casing of other flags for ctr's pull command#7341
dmcgowan merged 1 commit intocontainerd:mainfrom
my-git9:imagepull2

Conversation

@my-git9
Copy link
Copy Markdown
Contributor

@my-git9 my-git9 commented Aug 29, 2022

improve image pull output

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 29, 2022

Hi @my-git9. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcantah
dcantah approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a more descriptive title + commit message here? Reading this I assumed it was changing something behavior wise for functionality related to pulling images, but it's just matching the casing of other flags for ctr's pull command.

Change LGTM

@my-git9
Copy link
Copy Markdown
Contributor Author

my-git9 commented Sep 8, 2022

matching the casing of other flags for ctr's pull command.

OK

@my-git9 my-git9 changed the title improve image pull output chore: matching the casing of other flags for ctr's pull command Sep 8, 2022
@dmcgowan dmcgowan merged commit 3f3db40 into containerd:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@my-git9 @k8s-ci-robot @dmcgowan @samuelkarp @dcantah