replace sys Sequential funcs with moby/sys/sequential#7334
Merged
kzys merged 1 commit intocontainerd:mainfrom Aug 30, 2022
Merged
replace sys Sequential funcs with moby/sys/sequential#7334kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
Member
|
"without importing all of sys" ... Nice!!! ❤️ |
Member
Author
|
You may like #7335 as well :) |
Member
Author
|
For reviewers looking at the "+ LOC"; most of the added lines from the new module is because
|
thaJeztah
changed the title
thaJeztah
commented
Aug 29, 2022
| github.com/klauspost/compress v1.15.9 | ||
| github.com/moby/locker v1.0.1 | ||
| github.com/moby/sys/mountinfo v0.6.2 | ||
| github.com/moby/sys/sequential v0.0.0-20220829095930-b22ba8a69b30 |
Member
Author
There was a problem hiding this comment.
No release yet, but I'll do a release once review of all PR's is looking good, and will update to v0.5.0 (once release) in a follow-up.
Member
Author
|
@dims @AkihiroSuda this one should be ready for review 👍 |
thaJeztah
commented
Aug 29, 2022
Comment on lines
66
to
67
| // Source is regular file. We use sys.OpenFileSequential to use sequential | ||
| // file access to avoid depleting the standby list on Windows. |
Member
Author
There was a problem hiding this comment.
I should probably update the comments as well accordingly; let me fix that.
These functions were originally copied from the docker / moby repository in 4a7a8ef. Migrating these functions to use the github.com/moby/sys/sequential module allows them being shared between moby, docker/cli, and containerd, and to allow using them without importing all of sys which also depends on hcsshim and more. Signed-off-by: Sebastiaan van Stijn <[email protected]>
cpuguy83
approved these changes
Aug 29, 2022
Member
Author
|
Let me try close/reopen to give CI a kick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions were originally copied from the docker / moby repository in 4a7a8ef (#415). Migrating these functions to use the github.com/moby/sys/sequential module allows them being shared between moby, docker/cli, and containerd, and to allow using them without importing all of sys which also depends on hcsshim and more.