Skip to content

Add kubernetes v1.25 supported version as v1.24#7326

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
pacoxu:patch-4
Aug 31, 2022
Merged

Add kubernetes v1.25 supported version as v1.24#7326
samuelkarp merged 1 commit intocontainerd:mainfrom
pacoxu:patch-4

Conversation

@pacoxu
Copy link
Copy Markdown
Contributor

@pacoxu pacoxu commented Aug 26, 2022 •
edited
Loading

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 26, 2022

Hi @pacoxu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu pacoxu mentioned this pull request Aug 26, 2022
Closed
@kzys
Copy link
Copy Markdown
Member

kzys commented Aug 26, 2022

/ok-to-test

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 26, 2022

If updates are needed in the Pr; could you fix the typo in the commit message (kuberentes -> kubernetes)? In case we need to find back the commit, makes it easier 😁

@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Aug 27, 2022

If updates are needed in the Pr; could you fix the typo in the commit message (kuberentes -> kubernetes)? In case we need to find back the commit, makes it easier 😁

Updated. Sorry for the typo.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 27, 2022

No worries at all; thank you!

(It was a really minor issue, but experience taught me that a silly typo can make you spend some time scratching your head "where was that commit?")

Oh! Could you also edit the title on GitHub (looks like I don't have permissions to do so 😓)

@pacoxu pacoxu changed the title Add kuberentes v1.25 supported version as v1.24 Add kubernetes v1.25 supported version as v1.24 Aug 27, 2022
@pacoxu
Copy link
Copy Markdown
Contributor Author

pacoxu commented Aug 27, 2022 •
edited
Loading

title was updated now. Thanks.

dcantah
dcantah approved these changes Aug 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@samuelkarp samuelkarp merged commit f634868 into containerd:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pacoxu @k8s-ci-robot @kzys @thaJeztah @samuelkarp @dcantah