Revert "Downgrade MinGW to version 10.2.0" #7308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Member
Author
|
Lemme git revert the actual commit that added this for better tracking also |
This reverts commit 1ef4bda. Previously we were downgrading mingw to work around an issue in the race detector in Go on Windows when used with a newer version of GCC. The issue was first reported here: golang/go#46099 Shortly after the release of 1.19 someone had commented this issue was solved for them, and after trying it out in some test runs on actions machines, it seems to be the case. Disabling ASLR got things in order, and PIE was disabled for -race builds in 1.19, so this is likely the reason things work now: golang/go@0c7fcf6. The downgrade was mostly harmless except for two shortcomings: 1. It took quite a while for the package to get downloaded+installed. 2. Chocolatey would frequently fail to download with `The remote file either doesn't exist, is unauthorized, or is forbidden for url ... Exception calling "GetResponse" with "0" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."` Restarting the failed run would often resolve this, but a 50-50 shot of things working is not a great situation. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
rm-mingw-downgrade
branch
from
cfac9c4 to
912d43b
Compare
dcantah
changed the title
kzys
approved these changes
Aug 19, 2022
samuelkarp
approved these changes
Aug 19, 2022
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1ef4bda.
Previously we were downgrading mingw to work around an issue in the race
detector in Go on Windows when used with a newer version of GCC. The
issue was first reported here:
golang/go#46099
Shortly after the release of 1.19 someone had commented this issue was
solved for them, and after trying it out in some test runs on actions
machines, it seems to be the case. Disabling ASLR got things in order, and
PIE was disabled for -race builds in 1.19, so this is likely the reason
things work now:
golang/go@0c7fcf6.
The downgrade was mostly harmless except for two shortcomings:
It took quite a while for the package to get downloaded+installed.
Chocolatey would frequently fail to download with
The remote file either doesn't exist, is unauthorized, or is forbidden for url ... Exception calling "GetResponse" with "0" argument(s): "The request was aborted: Could not create SSL/TLS secure channel."Restarting thefailed run would often resolve this, but a 50-50 shot of things working
is not a great situation.