Skip to content

Don't fail test when GOOGLE_APPLICATION_CREDENTIALS is unset#7306

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
chaodaiG:fix-bash-bug
Aug 17, 2022
Merged

Don't fail test when GOOGLE_APPLICATION_CREDENTIALS is unset#7306
samuelkarp merged 1 commit intocontainerd:mainfrom
chaodaiG:fix-bash-bug

Conversation

@chaodaiG
Copy link
Copy Markdown
Contributor

@chaodaiG chaodaiG commented Aug 17, 2022

Workload identity is preferred in CI instead of GOOGLE_APPLICATION_CREDENTIALS

related: kubernetes/test-infra#27157

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims August 17, 2022 18:39
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 17, 2022

Hi @chaodaiG. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG
Copy link
Copy Markdown
Contributor Author

chaodaiG commented Aug 17, 2022

- FAIL - does not have a valid DCO, seems like I'm not a valid contributor?

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Aug 17, 2022

/ok-to-test

  • FAIL - does not have a valid DCO, seems like I'm not a valid contributor?

You're missing the Signed-off-by line in your git commit message; see https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

@chaodaiG
Don't fail test when GOOGLE_APPLICATION_CREDENTIALS is unset
13b1473 
Workload identity is preferred in CI instead of GOOGLE_APPLICATION_CREDENTIALS

Signed-off-by: Chao Dai <[email protected]>
dims
dims approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit 0fd000f into containerd:main Aug 17, 2022
@dims
Copy link
Copy Markdown
Member

dims commented Aug 17, 2022

thanks you all!

@dims dims mentioned this pull request Aug 17, 2022
Merged
@chaodaiG chaodaiG mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chaodaiG @k8s-ci-robot @samuelkarp @dims @estesp