Skip to content

feature: use client default namespace#7291

Merged
kzys merged 1 commit intocontainerd:mainfrom
lengrongfu:feat_client_defaultnamespace
Sep 6, 2022
Merged

feature: use client default namespace#7291
kzys merged 1 commit intocontainerd:mainfrom
lengrongfu:feat_client_defaultnamespace

Conversation

@lengrongfu
Copy link
Copy Markdown
Contributor

@lengrongfu lengrongfu commented Aug 15, 2022 •
edited
Loading

Signed-off-by: rongfu.leng [email protected]

ref: #6039

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 15, 2022

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dmcgowan
dmcgowan requested changes Aug 15, 2022
View reviewed changes
Comment thread .gitignore Outdated
Comment thread oci/client.go Outdated
Comment thread oci/spec_test.go Outdated
@lengrongfu lengrongfu force-pushed the feat_client_defaultnamespace branch 2 times, most recently from 6f188f9 to 6e25f44 Compare August 16, 2022 05:32
cpuguy83
cpuguy83 requested changes Aug 16, 2022
View reviewed changes
Comment thread oci/client.go Outdated
@lengrongfu lengrongfu force-pushed the feat_client_defaultnamespace branch from 6e25f44 to 4d3c3cb Compare August 22, 2022 01:20
@lengrongfu
Copy link
Copy Markdown
Contributor Author

lengrongfu commented Aug 27, 2022

@dmcgowan Hi, what else is there to fix about this pr

kzys
kzys approved these changes Aug 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cpuguy83 @dmcgowan Could you take a look again?

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Aug 31, 2022

/ok-to-test

mikebrow
mikebrow approved these changes Aug 31, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lengrongfu lengrongfu force-pushed the feat_client_defaultnamespace branch from 4d3c3cb to 5e57d46 Compare September 6, 2022 14:18
@kzys kzys merged commit 217aa16 into containerd:main Sep 6, 2022
@lengrongfu lengrongfu deleted the feat_client_defaultnamespace branch September 6, 2022 23:36
@strideynet strideynet mentioned this pull request Sep 19, 2022
Closed
@austinarbor
Copy link
Copy Markdown

austinarbor commented Feb 23, 2023

@kzys @lengrongfu when will this make it into a release? I see the PR code in main but it's not in the 1.6.18 release/tag. Is main stable enough to use instead of release branches in production code?

@kzys
Copy link
Copy Markdown
Member

kzys commented Feb 23, 2023

We probably don't backport this change to 1.6.x. We are preparing for 1.7.0 right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan requested changes

@fuweid fuweid fuweid left review comments

@cpuguy83 cpuguy83 cpuguy83 requested changes

@kzys kzys kzys approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lengrongfu @k8s-ci-robot @mikebrow @austinarbor @kzys @dmcgowan @cpuguy83 @fuweid