Skip to content

contrib/fuzz: fix broken OSS-Fuzz build#7288

Closed
AdamKorcz wants to merge 1 commit intocontainerd:mainfrom
AdamKorcz:build-fix10
Closed

contrib/fuzz: fix broken OSS-Fuzz build#7288
AdamKorcz wants to merge 1 commit intocontainerd:mainfrom
AdamKorcz:build-fix10

Conversation

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz AdamKorcz commented Aug 13, 2022

A broken fuzzer in an old version of github.com/cilium/ebpf breaks the OSS-Fuzz build. This PR fixes that by using the latest version of the dependency which does not have the broken fuzzer.

Signed-off-by: AdamKorcz [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Aug 13, 2022

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpuguy83
cpuguy83 requested changes Aug 15, 2022
View reviewed changes
Comment thread contrib/fuzz/oss_fuzz_build.sh
go mod tidy
rm vendor/github.com/cilium/ebpf/internal/btf/fuzz.go
rm /root/go/pkg/mod/github.com/cilium/[email protected]/internal/btf/fuzz.go
go get github.com/cilium/ebpf@latest
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this get a specific version so it doesn't break later?

Copy link
Copy Markdown
Member

@kzys kzys Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kzys
Copy link
Copy Markdown
Member

kzys commented Aug 16, 2022

We should upgrade containerd/cgroups instead of patching that in this shell script.

containerd/cgroups#241

kzys pushed a commit to kzys/containerd that referenced this pull request Aug 16, 2022
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
f493c23 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys mentioned this pull request Aug 16, 2022
Merged
kzys pushed a commit to kzys/containerd that referenced this pull request Aug 17, 2022
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
8e421c0 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys pushed a commit to kzys/containerd that referenced this pull request Aug 17, 2022
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
470d3ee 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 18, 2022 •
edited
Loading

this needs a rebase after #7304 was merged (conflicts with changes to the oss_fuzz_build.sh script)

actually; I see now that this change is superseded by #7304 so I think we can close this PR as it should be fixed.

@estesp
Copy link
Copy Markdown
Member

estesp commented Aug 18, 2022

Closing per fix in #7304

@estesp estesp closed this Aug 18, 2022
vvejell1 pushed a commit to vvejell1/containerd that referenced this pull request Nov 4, 2022
@vvejell1
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
a58519e 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
jsturtevant pushed a commit to jsturtevant/containerd that referenced this pull request Sep 21, 2023
@jsturtevant
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
f5fbbe2 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
kiashok pushed a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
Upgrade containerd/cgroups to remove github.com/cilium/ebpf's fuzzer
7b874f4 
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys left review comments

@cpuguy83 cpuguy83 cpuguy83 requested changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AdamKorcz @k8s-ci-robot @kzys @estesp @cpuguy83