go.mod: Bump hcsshim to v0.10.0-rc.1#7284
Merged
kevpar merged 2 commits intocontainerd:mainfrom Aug 17, 2022
Merged
Conversation
e355513 to
e866d89
Compare
Member
Author
|
I'll need to rebase after this lands to fix the CI issues #7293 |
This contains quite a bit (also bumps google/uuid to 1.3.0). Some HostProcess container improvements to get ready for whenever it goes to stable in Kubernetes, Hyper-V (windows) container support for CRI, and a plethora of other small additions and fixes. Signed-off-by: Daniel Canter <[email protected]>
Previously in the Windows shim, killing a task that has already exited or a task that has not yet been started, yielded an ErrNotFound. We now return nil, which is in line with how the linux runtime behaves, so remove the special case we had in TestContainerdRestart for this. Signed-off-by: Daniel Canter <[email protected]>
554abfe to
0950447
Compare
dmcgowan
approved these changes
Aug 16, 2022
Member
|
/retest |
kzys
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains quite a bit (also bumps google/uuid to 1.3.0). Some HostProcess
container improvements to get ready for whenever it goes to stable in
Kubernetes, Hyper-V (windows) container support for CRI, and a plethora of
other small additions and fixes.
This change additionally removes a special casing in TestContainerRestart for
the Windows runtime. Killing a task that has already exited or a task that had not
yet been started, yielded an ErrNotFound previously. We now return nil, which is in
line with how the linux runtime behaves, so no more need for the different err check.