Skip to content

go.mod: Bump hcsshim to v0.10.0-rc.1#7284

Merged
kevpar merged 2 commits intocontainerd:mainfrom
dcantah:hcsshim-bump-0.10
Aug 17, 2022
Merged

go.mod: Bump hcsshim to v0.10.0-rc.1#7284
kevpar merged 2 commits intocontainerd:mainfrom
dcantah:hcsshim-bump-0.10

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Aug 13, 2022

This contains quite a bit (also bumps google/uuid to 1.3.0). Some HostProcess
container improvements to get ready for whenever it goes to stable in
Kubernetes, Hyper-V (windows) container support for CRI, and a plethora of
other small additions and fixes.

This change additionally removes a special casing in TestContainerRestart for
the Windows runtime. Killing a task that has already exited or a task that had not
yet been started, yielded an ErrNotFound previously. We now return nil, which is in
line with how the linux runtime behaves, so no more need for the different err check.

@dcantah dcantah force-pushed the hcsshim-bump-0.10 branch from e355513 to e866d89 Compare August 13, 2022 06:52
@dcantah dcantah closed this Aug 13, 2022
@dcantah dcantah reopened this Aug 13, 2022
@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Aug 15, 2022

I'll need to rebase after this lands to fix the CI issues #7293

This contains quite a bit (also bumps google/uuid to 1.3.0). Some HostProcess
container improvements to get ready for whenever it goes to stable in
Kubernetes, Hyper-V (windows) container support for CRI, and a plethora of
other small additions and fixes.

Signed-off-by: Daniel Canter <[email protected]>
Previously in the Windows shim, killing a task that has already exited
or a task that has not yet been started, yielded an ErrNotFound. We now
return nil, which is in line with how the linux runtime behaves, so remove
the special case we had in TestContainerdRestart for this.

Signed-off-by: Daniel Canter <[email protected]>
@dcantah dcantah force-pushed the hcsshim-bump-0.10 branch from 554abfe to 0950447 Compare August 16, 2022 00:04
@kzys
Copy link
Copy Markdown
Member

kzys commented Aug 16, 2022

/retest

Copy link
Copy Markdown
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants