[release/1.6] Backport Windows HostProcess test improvements#7227
Merged
estesp merged 2 commits intocontainerd:release/1.6from Jul 29, 2022
Merged
[release/1.6] Backport Windows HostProcess test improvements#7227estesp merged 2 commits intocontainerd:release/1.6from
estesp merged 2 commits intocontainerd:release/1.6from
Conversation
HostProcess containers require every container in the pod to be a host process container and have the corresponding field set. The Kubelet usually enforces this so we'd error before even getting here but we recently found a bug in this logic so better to be safe than sorry. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit 978ff39) Signed-off-by: Daniel Canter <[email protected]>
Add a test to the CRI suite to validate stats functions for hostprocess containers. hcsshim v0.9.3 had a bug in stats collection so this is mainly for sanity and to avoid another regression. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit b16c3e9) Signed-off-by: Daniel Canter <[email protected]>
fuweid
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick 🍒:
#6996
#7223