Skip to content

Windows HostProcess container CRI stats test#7223

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
dcantah:hpc-stats
Jul 28, 2022
Merged

Windows HostProcess container CRI stats test#7223
dmcgowan merged 1 commit intocontainerd:mainfrom
dcantah:hpc-stats

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Jul 27, 2022

Add a test to the CRI suite to validate stats functions for hostprocess
containers. hcsshim v0.9.3 had a bug in stats collection so this is
mainly for sanity and to avoid another regression.

@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Jul 27, 2022

cc @marosset @jsturtevant

@dcantah dcantah marked this pull request as draft July 27, 2022 22:41
Add a test to the CRI suite to validate stats functions for hostprocess
containers. hcsshim v0.9.3 had a bug in stats collection so this is
mainly for sanity and to avoid another regression.

Signed-off-by: Daniel Canter <[email protected]>
@dcantah dcantah marked this pull request as ready for review July 27, 2022 22:47
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit d4b80b8 into containerd:main Jul 28, 2022
@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Jul 28, 2022

Thanks Derek, cherry-picking to 1.6 shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants