Skip to content

Use httputil.DumpRequestOut for dumping client req#7221

Merged
fuweid merged 1 commit intocontainerd:mainfrom
jonnystoten:fix-http-debug
Jul 27, 2022
Merged

Use httputil.DumpRequestOut for dumping client req#7221
fuweid merged 1 commit intocontainerd:mainfrom
jonnystoten:fix-http-debug

Conversation

@jonnystoten
Copy link
Copy Markdown
Contributor

httputil.DumpRequest is only for dumping incoming requests on a server.

httputil.DumpRequest is only for dumping incoming requests on a server.

Signed-off-by: Jonny Stoten <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @jonnystoten. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 5af0edb into containerd:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants