fix: support simultaneous create diff for same parent snapshot#7204
Merged
fuweid merged 1 commit intocontainerd:mainfrom Jul 29, 2022
Merged
Conversation
|
Hi @cosmoer. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AkihiroSuda
reviewed
Jul 23, 2022
cosmoer
force-pushed
the
fix-support-simultaneous-create-diff
branch
from
2dfe33d to
b695622
Compare
Signed-off-by: Qian Zhang <[email protected]>
cosmoer
force-pushed
the
fix-support-simultaneous-create-diff
branch
from
b695622 to
344431c
Compare
dmcgowan
approved these changes
Jul 27, 2022
fuweid
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CreateDiff function, we wil create view snapshot base on parent snapshot,
view snapshot name is "
<parent snapshot KEY>-parent-view",so while, It does not support concurrent operations，other user will be return to the error that the snapshot already exists.
So, we add uniquePart() as a suffix.