Skip to content

test: error strings should not be capitalized#7195

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
falser101:feature/cleanup
Jul 27, 2022
Merged

test: error strings should not be capitalized#7195
dmcgowan merged 1 commit intocontainerd:mainfrom
falser101:feature/cleanup

Conversation

@falser101
Copy link
Copy Markdown
Contributor

@falser101 falser101 commented Jul 21, 2022

Signed-off-by: jianfei.zhang [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 21, 2022

Hi @falser101. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fuweid
fuweid requested changes Jul 21, 2022
View reviewed changes
Comment thread client.go Outdated
Comment thread snapshots/native/native.go Outdated
AkihiroSuda
AkihiroSuda reviewed Jul 22, 2022
View reviewed changes
Comment thread client.go
@falser101 falser101 requested a review from fuweid July 23, 2022 02:23
fuweid
fuweid reviewed Jul 25, 2022
View reviewed changes
Comment thread snapshots/testsuite/helpers.go
@fuweid fuweid changed the title fix:fmt error string and handle err test: error strings should not capitalized Jul 26, 2022
@fuweid fuweid changed the title test: error strings should not capitalized test: error strings should not be capitalized Jul 26, 2022
fuweid
fuweid requested changes Jul 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits and use subject like 'test: error strings should not be capitalized' since there is no change for handle error :) and would you mind to update your signoff name like 'Jianfei Zhang'? Thanks

@falser101
Copy link
Copy Markdown
Contributor Author

falser101 commented Jul 26, 2022

Please squash commits and use subject like 'test: error strings should not be capitalized' since there is no change for handle error :) and would you mind to update your signoff name like 'Jianfei Zhang'? Thanks

Done.

@falser101 falser101 requested a review from fuweid July 26, 2022 02:00
@dmcgowan dmcgowan merged commit b848924 into containerd:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@falser101 @k8s-ci-robot @dmcgowan @AkihiroSuda @fuweid