Skip to content

adds an env var commented out for sandboxed mode#7183

Merged
fuweid merged 1 commit intocontainerd:mainfrom
mikebrow:add-service-environment-for-sandboxed
Jul 23, 2022
Merged

adds an env var commented out for sandboxed mode#7183
fuweid merged 1 commit intocontainerd:mainfrom
mikebrow:add-service-environment-for-sandboxed

Conversation

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow mikebrow commented Jul 19, 2022

@mxpv
Signed-off-by: Mike Brown [email protected]

fuweid
fuweid reviewed Jul 19, 2022
View reviewed changes
Comment thread containerd.service
mxpv
mxpv approved these changes Jul 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow force-pushed the add-service-environment-for-sandboxed branch from 92b3e6a to dcb7097 Compare July 21, 2022 00:02
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 21, 2022

@mikebrow: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-containerd-build
  • /test pull-containerd-node-e2e
  • /test pull-containerd-sandboxed-node-e2e

Use /test all to run the following jobs that were automatically triggered:

  • pull-containerd-build
  • pull-containerd-node-e2e
Details

In response to this:

/test pull-containerd-node-e2e-sandboxed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Jul 21, 2022

/test pull-containerd-sandboxed-node-e2e

@mikebrow mikebrow force-pushed the add-service-environment-for-sandboxed branch from dcb7097 to 904e613 Compare July 21, 2022 02:08
@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Jul 21, 2022

/test pull-containerd-sandboxed-node-e2e

@mikebrow mikebrow marked this pull request as draft July 21, 2022 02:21
@mikebrow mikebrow force-pushed the add-service-environment-for-sandboxed branch from 904e613 to 6b67f52 Compare July 21, 2022 02:23
@mikebrow mikebrow marked this pull request as ready for review July 21, 2022 02:24
@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Jul 21, 2022

/test pull-containerd-node-e2e

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 21, 2022 •
edited
Loading

@mikebrow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-sandboxed-node-e2e dcb7097 link true /test pull-containerd-sandboxed-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jul 22, 2022

Need to rebase with #7198 ~

@mikebrow mikebrow force-pushed the add-service-environment-for-sandboxed branch from 6b67f52 to ee6fc5c Compare July 22, 2022 22:13
@fuweid fuweid merged commit 294c61f into containerd:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mikebrow @k8s-ci-robot @fuweid @dmcgowan @mxpv @dcantah