Skip to content

docs: Fix sample config.toml syntax #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Jul 18, 2022
Merged

docs: Fix sample config.toml syntax #7174

dmcgowan merged 1 commit into from
Jul 18, 2022

Conversation

@oradwell
Copy link
Contributor

@oradwell oradwell commented Jul 16, 2022 •
edited
Loading

Sample config.toml has a syntax error. Gives the following error when used:

containerd: failed to load TOML: /etc/containerd/config.toml: (27, 47):
was expecting token [[, but got table array key cannot contain ']' instead

Also changed to have syntax highlighting. Syntax highlighting would have marked the error in red

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jul 16, 2022

Hi @oradwell. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AkihiroSuda AkihiroSuda added kind/docs cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-pick/1.5.x and removed cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch labels Jul 17, 2022
estesp
estesp approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 11ded16 into containerd:main Jul 18, 2022
@oradwell oradwell deleted the patch-1 branch July 19, 2022 07:42
@thaJeztah thaJeztah mentioned this pull request Jul 14, 2023
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.5.x labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch kind/docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@oradwell @k8s-ci-robot @samuelkarp @estesp @AkihiroSuda @mikebrow @dmcgowan @thaJeztah