test: Add ability to switch between cgroupv1 or cgroupv2 for node e2e#7173
test: Add ability to switch between cgroupv1 or cgroupv2 for node e2e#7173mikebrow merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @bobbypage. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
k/k test-infra changes - kubernetes/test-infra#26831 |
|
I've approved this, but if you rebase on |
|
Thanks, @samuelkarp I have rebased on main. |
For k8s e2e node tests, we want to be able to test both cgroupv1 and cgroupv2 variants. Currently, the latest version of COS (M97) is running as cgroupv2 and we would like the add the ability to switch to cgroupv1 for running tests on cgroupv1. To do this, add a new flag, "CGROUP_MODE" which can be set as v1 or v2. If the current cgroup configuration does not match the desired config, the cgroup config will be set via `cgroup_helper` COS utility, and the node will be rebooted. Signed-off-by: David Porter <[email protected]>
|
Thanks @mikebrow for the comments, updated as per you suggestions. PTAL again. Thanks! |
6 participants
For k8s e2e node tests, we want to be able to test both cgroupv1 and
cgroupv2 variants. Currently, the latest version of COS (M97) is running
as cgroupv2 and we would like the add the ability to switch to cgroupv1
for running tests on cgroupv1.
To do this, add a new flag, "CGROUP_MODE" which can be set as v1 or v2.
If the current cgroup configuration does not match the desired config,
the cgroup config will be set via
cgroup_helperCOS utility, and thenode will be rebooted.
Signed-off-by: David Porter [email protected]