Skip to content

prevent Server reuse after a Shutdown#7165

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
zouyee:nit
Dec 22, 2022
Merged

prevent Server reuse after a Shutdown#7165
dmcgowan merged 1 commit intocontainerd:mainfrom
zouyee:nit

Conversation

@zouyee
Copy link
Copy Markdown
Contributor

@zouyee zouyee commented Jul 14, 2022

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 14, 2022

Hi @zouyee. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcantah
dcantah reviewed Jul 14, 2022
View reviewed changes
Comment thread pkg/cri/server/service.go Outdated
@zouyee zouyee requested a review from dcantah July 25, 2022 13:46
dcantah
dcantah approved these changes Jul 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zouyee
Copy link
Copy Markdown
Contributor Author

zouyee commented Sep 26, 2022

/cc @thaJeztah

@samuelkarp samuelkarp closed this Oct 26, 2022
@samuelkarp samuelkarp reopened this Oct 26, 2022
@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Oct 26, 2022

Close/reopen to kick CI; the runs were too old for GitHub's rerun button to show up.

@ruiwen-zhao
Copy link
Copy Markdown
Member

ruiwen-zhao commented Dec 8, 2022

/lgtm

mikebrow
mikebrow approved these changes Dec 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp
Copy link
Copy Markdown
Member

samuelkarp commented Dec 10, 2022

/ok-to-test

@dmcgowan dmcgowan merged commit b3b7981 into containerd:main Dec 22, 2022
@fuweid fuweid added the cherry-picked/sbserver Changes are backported to sbserver label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcantah dcantah dcantah approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@mikebrow mikebrow mikebrow approved these changes

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees

No one assigned

Labels

cherry-picked/sbserver Changes are backported to sbserver ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zouyee @k8s-ci-robot @samuelkarp @ruiwen-zhao @dmcgowan @mikebrow @dcantah @fuweid