Skip to content

ctr: support --user for run/create#7145

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
junnplus:ctr-user
Jul 19, 2022
Merged

ctr: support --user for run/create#7145
dmcgowan merged 1 commit intocontainerd:mainfrom
junnplus:ctr-user

Conversation

@junnplus
Copy link
Copy Markdown
Member

@junnplus junnplus commented Jul 8, 2022

Signed-off-by: Ye Sijun [email protected]

$ sudo ctr run --rm --user 1000 docker.io/library/alpine:latest test id
uid=1000 gid=0(root) groups=1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)

$ sudo ctr run --rm --user 1000:1000 docker.io/library/alpine:latest test id
uid=1000 gid=1000

dcantah
dcantah reviewed Jul 11, 2022
View reviewed changes
Comment thread cmd/ctr/commands/run/run_windows.go Outdated
estesp
estesp approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow approved these changes Jul 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 79fcc38 into containerd:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@junnplus @dmcgowan @estesp @mikebrow @dcantah