[release/1.6] Downgrade MinGW to version 10.2.0#7133
Merged
mikebrow merged 1 commit intocontainerd:release/1.6from Jul 5, 2022
Merged
[release/1.6] Downgrade MinGW to version 10.2.0#7133mikebrow merged 1 commit intocontainerd:release/1.6from
mikebrow merged 1 commit intocontainerd:release/1.6from
Conversation
There is currently an issue in the race detector in Go on Windows when used with a newer version of GCC. The issue was first reported here: golang/go#46099 Fixes containerd#7104 Signed-off-by: Gabriel Adrian Samfira <[email protected]> (cherry picked from commit 1ef4bda) Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Skipping CI for Draft Pull Request. |
Member
Author
|
#7131 was having the following issue. @gabriel-samfira does it make sense to backport the change to 1.5 branch as well? |
Contributor
|
@kzys this will happen in any environment with a mingw version above 10.2.0 so it will need to be backported to all supported branches. Sadly, the default GitHub runners have an updated version of MinGW. |
Member
Author
|
@gabriel-samfira Thanks! Opening #7134 for 1.5.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:
golang/go#46099
Fixes #7104
Signed-off-by: Gabriel Adrian Samfira [email protected]
(cherry picked from commit 1ef4bda)
Signed-off-by: Kazuyoshi Kato [email protected]