Skip to content

fix incorrect namespace of event when create/update namespace #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Jan 20, 2023
Merged

fix incorrect namespace of event when create/update namespace #7129

dmcgowan merged 1 commit into from
Jan 20, 2023

Conversation

@junnplus
Copy link
Member

@junnplus junnplus commented Jul 5, 2022 •
edited
Loading

fuweid
fuweid reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Currently, there is only Delete API using the target namespace when publish event.
The ctx might use A namespace to create/update/delete B namespace, but the
event content belongs to the B namespace. IMO, I think we can align the rest of
APIs with Delete.

@junnplus
Copy link
Member Author

junnplus commented Jul 13, 2022

@Random-Liu PTAL

@containerd/committers What do other maintainers think?

mikebrow
mikebrow approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@dmcgowan dmcgowan merged commit beabd3d into containerd:main Jan 20, 2023
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 7534707: Update fork-external/main with upstream containerd…
f02f374 
…/main

Update fork-external/main with upstream containerd/containerd/main at commit hash 3d32da8

Related work items: containerd#5674, containerd#7129, containerd#7393, containerd#7661, containerd#7685, containerd#7810, containerd#7850, containerd#7861, containerd#7882, containerd#7883, containerd#7886, containerd#7891, containerd#7892, containerd#7893, containerd#7903, containerd#7904, containerd#7905, containerd#7906, containerd#7907, containerd#7908, containerd#7911, containerd#7913, containerd#7914, containerd#7917, containerd#7925, containerd#7927, containerd#7928, containerd#7929, containerd#7932, containerd#7935, containerd#7943, containerd#7946, containerd#7948, containerd#7957, containerd#7958, containerd#7959, containerd#7960, containerd#7963, containerd#7968, containerd#7969, containerd#7970, containerd#7973, containerd#7985, containerd#7987, containerd#7994, containerd#8005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid left review comments

@dmcgowan dmcgowan dmcgowan approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@junnplus @dmcgowan @mikebrow @fuweid