Skip to content

update some devmapper docs#7124

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
ginglis13:devmapper-docs
Jul 12, 2022
Merged

update some devmapper docs#7124
samuelkarp merged 1 commit intocontainerd:mainfrom
ginglis13:devmapper-docs

Conversation

@ginglis13
Copy link
Copy Markdown
Contributor

@ginglis13 ginglis13 commented Jul 1, 2022

Updated some documentation for devmapper snapshotter plugin.
Made consistent use of "thin-pool", "Device Mapper" when referring to
the volume management framework, and "devmapper" when referring to the
snapshotter plugin itself.

Also added some additional resources / reorg.

Signed-off-by: Gavin Inglis [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jul 1, 2022

Hi @ginglis13. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kzys
kzys reviewed Jul 1, 2022
View reviewed changes
Comment thread docs/snapshotters/devmapper.md Outdated
Comment thread docs/snapshotters/devmapper.md Outdated
@ginglis13 ginglis13 force-pushed the devmapper-docs branch 2 times, most recently from 9c7915c to 7a03a0c Compare July 1, 2022 20:13
kzys
kzys approved these changes Jul 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mxpv Can you take a look?

samuelkarp
samuelkarp reviewed Jul 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the additional context and making the doc more consistent! I have a couple suggestions on improvements.

Comment thread docs/snapshotters/devmapper.md Outdated
Comment thread docs/snapshotters/devmapper.md Outdated
samuelkarp
samuelkarp approved these changes Jul 6, 2022
View reviewed changes
Comment thread docs/snapshotters/devmapper.md Outdated
Comment thread docs/snapshotters/devmapper.md Outdated
@ginglis13
update some devmapper docs
174b013 
Updated some documentation for devmapper snapshotter plugin.
Made consistent use of "thin-pool", "Device Mapper" when referring to
the volume management framework, and "devmapper" when referring to the
snapshotter plugin itself.

Also added some additional resources / reorg.

Signed-off-by: Gavin Inglis <[email protected]>
@ginglis13 ginglis13 requested a review from samuelkarp July 11, 2022 16:03
@samuelkarp samuelkarp merged commit efd1ff7 into containerd:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@mxpv mxpv mxpv approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ginglis13 @k8s-ci-robot @kzys @samuelkarp @mxpv @fuweid @dcantah