Skip to content

Copy fuzzers from github.com/cncf/cncf-fuzzing #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 2 commits into from
Jul 6, 2022
Merged

Copy fuzzers from github.com/cncf/cncf-fuzzing #7123

dmcgowan merged 2 commits into from
Jul 6, 2022

Conversation

@kzys
Copy link
Member

@kzys kzys commented Jul 1, 2022 •
edited
Loading

This commit copies the fuzzers from the repository except for
containerd_import_structured_fuzzer.go.

Signed-off-by: Kazuyoshi Kato [email protected]

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jul 1, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kzys kzys force-pushed the fuzz branch 7 times, most recently from 7628922 to fe4ba1c Compare July 1, 2022 18:05
@kzys kzys marked this pull request as ready for review July 1, 2022 18:20
@kzys
Copy link
Member Author

kzys commented Jul 1, 2022

@AdamKorcz Please take a look.

@kzys kzys mentioned this pull request Jul 5, 2022
Closed
@kzys
Copy link
Member Author

kzys commented Jul 6, 2022

@AdamKorcz Is it possible to measure the efficiency (e.g. # of lines covered / iterations?) of a fuzzer? I'm wondering about https://github.com/cncf/cncf-fuzzing/blob/c402ef33d7a399d1c00c009d51df910e30dfe00a/projects/containerd/containerd_import_structured_fuzzer.go#L73-L79. Does it make sense to have both

containerd/contrib/fuzz/containerd_import_fuzzer.go

Line 66 in c4b1b36

func FuzzContainerdImport(data []byte) int {
and containerd_import_structured_fuzzer.go?

@AdamKorcz
Copy link
Contributor

AdamKorcz commented Jul 6, 2022 •
edited
Loading

@AdamKorcz Is it possible to measure the efficiency (e.g. # of lines covered / iterations?) of a fuzzer? I'm wondering about https://github.com/cncf/cncf-fuzzing/blob/c402ef33d7a399d1c00c009d51df910e30dfe00a/projects/containerd/containerd_import_structured_fuzzer.go#L73-L79. Does it make sense to have both

containerd/contrib/fuzz/containerd_import_fuzzer.go

Line 66 in c4b1b36

func FuzzContainerdImport(data []byte) int {

and containerd_import_structured_fuzzer.go?

The simplest test is to run these fuzzers over a defined time (for example 2 hours) and observe its coverage. As far as I remember, the structured fuzzer outperforms the non-structured one significantly. However, there might be value in having a fuzzer that generates more random input than the structured one, for example if the structured one does not reach all code.

Kazuyoshi Kato added 2 commits July 6, 2022 15:21
Upgrade github.com/AdaLogics/go-fuzz-headers
b316318 
Signed-off-by: Kazuyoshi Kato <[email protected]>
Copy fuzzers from github.com/cncf/cncf-fuzzing
e9e33f8 
This commit copies the fuzzers from the repository except for
containerd_import_structured_fuzzer.go.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys
Copy link
Member Author

kzys commented Jul 6, 2022

This one is ready for review. I will work on containerd_import_structured_fuzzer.go in a different PR since this PR is already big.

estesp
estesp approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 681aaf6 into containerd:main Jul 6, 2022
kzys pushed a commit to kzys/cncf-fuzzing that referenced this pull request Aug 18, 2022
containerd: remove fuzzers that are in the upstream
d46762e 
They are copied to containerd's repos in
containerd/containerd#7123.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys kzys mentioned this pull request Aug 18, 2022
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

+1 more reviewer

@AdamKorcz AdamKorcz AdamKorcz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kzys @k8s-ci-robot @AdamKorcz @dmcgowan @estesp