Skip to content

Update go-restful/v3 to latest release#7117

Merged
fuweid merged 1 commit intocontainerd:mainfrom
estesp:update-restful
Jun 30, 2022
Merged

Update go-restful/v3 to latest release#7117
fuweid merged 1 commit intocontainerd:mainfrom
estesp:update-restful

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Jun 29, 2022

This dependency had a security release and it's worth updating our dependency, but for those curious, the containerd code which uses this vendored library (pkg/cri/streaming) does not use CORS at all, which is a requirement to be able to exploit the restful CVE. Therefore containerd is not vulnerable to this exploit.

Full diff: emicklei/go-restful@7c971ca...v3.8.0

Signed-off-by: Phil Estes [email protected]

@thaJeztah
Copy link
Copy Markdown
Member

Some issue with vendoring;

+ verify-vendor
go: downloading github.com/Microsoft/hcsshim/test v0.0.0-20210408205431-da33ecd607e1
Files /home/runner/work/containerd/containerd/src/github.com/containerd/containerd/integration/client/go.sum and /tmp/tmp.d2FTY9RXzr/containerd/integration/client/go.sum differ
make: *** [verify-vendor] Error 1
Makefile:437: recipe for target 'verify-vendor' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants