Hi @rata. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Run go mod tidy on integration/client/go.mod to make the "Project Checks" CI happy (was failing with: https://github.com/containerd/containerd/runs/7112351330?check_suite_focus=true)

Hmm, will we have a release with the alpha version of kubernetes in our go.mod? (i'd rather not!)

Uhm, CI sesm to have issues connecting to some mirrors:

E: Failed to fetch http://ppa.launchpad.net/criu/ppa/ubuntu/pool/main/c/criu/criu_3.17-2ppa2.18.04_amd64.deb  Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1::3e). - connect (101: Network is unreachable) Could not connect to ppa.launchpad.net:80 (185.125.190.52), connection timed out

will hard push with no changes to restart the job

@dims why not? Can you please elaborate? We will change it before the containerd final release, of course.

We did it already in b69bbe2, for example. I don't see what it can be the problem. The diff is quite simple (https://github.com/containerd/containerd/pull/7114/files#diff-46912defa88ac8ecb8a26d0bb63c852b326099ab033b0385fa4d670776f39f69) and was reviewed several times in the KEP and in the code change. Sure, we will change the version used in go.mod to the final one later (once that is available), but it will not change the code it will just change the name of the tag

Rebased and the CI is happy now :)

Hmm, will we have a release with the alpha version of kubernetes in our go.mod? (i'd rather not!)

What is the timeline for 0.25? It seems we have enough time before the release to get this off alpha

@dmcgowan The final release is expected by end of august (https://github.com/kubernetes/sig-release/tree/master/releases/release-1.25), so yes, we should have lot of time to update before the final containerd release.

/ok-to-test