pkg/cri: use marshal wrapper for version convertor#7108
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Jun 29, 2022
Merged
pkg/cri: use marshal wrapper for version convertor#7108dmcgowan merged 1 commit intocontainerd:mainfrom
dmcgowan merged 1 commit intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Member
Author
unexpected error in windows... |
kzys
reviewed
Jun 29, 2022
Use wrapper for ReopenContainerLog v1alpha proto. Ref: containerd#5619 Signed-off-by: Wei Fu <[email protected]>
mikebrow
approved these changes
Jun 29, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM thx looks like I missed one
kzys
approved these changes
Jun 29, 2022
dmcgowan
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use wrapper for ReopenContainerLog v1alpha proto.
Ref: #5619
Signed-off-by: Wei Fu [email protected]