Skip to content

Conversation

@gabriel-samfira
Copy link
Contributor

There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:

golang/go#46099

Fixes #7104

Signed-off-by: Gabriel Adrian Samfira [email protected]

@k8s-ci-robot
Copy link

Hi @gabriel-samfira. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment. Thanks!!

There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:

golang/go#46099

Fixes #7104

Signed-off-by: Gabriel Adrian Samfira <[email protected]>
@dcantah
Copy link
Member

dcantah commented Jun 27, 2022

The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run 😐

@gabriel-samfira
Copy link
Contributor Author

The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run neutral_face

The default Github runners are not that beefy, unfortunately. It takes a while to download+install+generate the shims. Will let them finish before sending the update with the comment to the Downgrade step.

@estesp
Copy link
Member

estesp commented Jun 27, 2022

The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run 😐

I was worried about hitting the timeout but looks like we have it at 50m for Windows integration runs and at 33m we are on the last 2 steps, so at least that part should be fine (and this is on ws2022 which took 3.5 minutes longer for the downgrade than 2019)

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabriel-samfira
Copy link
Contributor Author

Looks like the ThreadSanitizer issue didn't pop up. Adding the comment and pushing.

@estesp estesp merged commit 813780e into containerd:main Jun 27, 2022
@fuweid fuweid added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test case in windows: ThreadSanitizer failed to allocate 0x000003f29000 (66228224) bytes at 0x200dbdaa74000 (error code: 87)

5 participants