-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Downgrade MinGW to version 10.2.0 #7106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @gabriel-samfira. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment. Thanks!!
There is currently an issue in the race detector in Go on Windows when used with a newer version of GCC. The issue was first reported here: golang/go#46099 Fixes #7104 Signed-off-by: Gabriel Adrian Samfira <[email protected]>
|
The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run 😐 |
The default Github runners are not that beefy, unfortunately. It takes a while to download+install+generate the shims. Will let them finish before sending the update with the comment to the Downgrade step. |
I was worried about hitting the timeout but looks like we have it at 50m for Windows integration runs and at 33m we are on the last 2 steps, so at least that part should be fine (and this is on ws2022 which took 3.5 minutes longer for the downgrade than 2019) |
estesp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Looks like the ThreadSanitizer issue didn't pop up. Adding the comment and pushing. |
There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:
golang/go#46099
Fixes #7104
Signed-off-by: Gabriel Adrian Samfira [email protected]