refactor: reduce duplicate code#7100
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Jun 27, 2022
Merged
Conversation
akhilerm
reviewed
Jun 24, 2022
Member
akhilerm
left a comment
akhilerm
left a comment
There was a problem hiding this comment.
Given a comment regarding the function name.
mikebrow
reviewed
Jun 24, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
since making funcs out of these and using twice.. might as well do them up proper and add unit tests for them?
Other than the option of adding unit buckets and naming the funcs, this LGTM.
junnplus
force-pushed
the
spec-opts
branch
2 times, most recently
from
2f414e7 to
1ccd133
Compare
Member
Author
|
@mikebrow I added two unit tests for |
Signed-off-by: Ye Sijun <[email protected]>
dmcgowan
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ye Sijun [email protected]