ctr: Fix ctr c create fails to parse arguments
#7098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kohei Tokunaga <[email protected]>
dmcgowan
approved these changes
Jun 25, 2022
samuelkarp
approved these changes
Jun 25, 2022
Member
|
merging now that we know the Windows failure (on almost all PRs) is a core Go/gcc issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctr c createdoesn't seems to parse container's arguments correctly.This seems related to urfave/cli#1424 .
This commit is a quick fix of this problem by adding
SkipArgReorder: true.This is the same approach as
ctr runandctr t exec.