Skip to content

make xattr EPERM non-fatal in createTarFile#7094

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
junnplus:xattr
Jun 25, 2022
Merged

make xattr EPERM non-fatal in createTarFile#7094
samuelkarp merged 1 commit intocontainerd:mainfrom
junnplus:xattr

Conversation

@junnplus
Copy link
Copy Markdown
Member

Signed-off-by: Ye Sijun [email protected]

Fixes: #7093

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@junnplus junnplus marked this pull request as ready for review June 22, 2022 16:46
Comment thread archive/tar.go Outdated
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys
Copy link
Copy Markdown
Member

kzys commented Jun 23, 2022

@samuelkarp Can you take a look since you've reviewed this once?

@samuelkarp samuelkarp merged commit 279f406 into containerd:main Jun 25, 2022
@rkujawa
Copy link
Copy Markdown

rkujawa commented Sep 21, 2022

@samuelkarp Would you be so kind as to pull this into release branch? It was fixed in June, but latest release of containerd still does not include this fix. I'm hitting this problem on my production environment.

@estesp estesp added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.5.x labels Sep 29, 2022
@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 29, 2022

@rkujawa just added this fix for both supported release branches; next release of both should include this fix

@rudesome rudesome mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to extract layer due to operation not permitted error

8 participants