Remove hacks around contrib/fuzz #7087
Conversation
|
Skipping CI for Draft Pull Request. |
kzys
force-pushed
the
fuzz-less-hacks
branch
7 times, most recently
from
dcdd645 to
5f7f75e
Compare
kzys
force-pushed
the
fuzz-less-hacks
branch
3 times, most recently
from
33a97ca to
f11d284
Compare
containerd/containerd#7087 will move the fuzzer to the upstream. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Really nice work @kzys! Let me know if I should review anything. |
| ) | ||
|
|
||
| func startDaemonForFuzzing(arguments []string) { | ||
| app := command.App() |
There was a problem hiding this comment.
Note to reviewers: This fuzzer is starting containerd by instantiating command.App directly. To have all containerd's plugins, it has to have all of _ "github.com/containerd/containerd/.../plugin" import and that's why we need builtins package.
There was a problem hiding this comment.
@AdamKorcz Regarding directly instantiating fuzzers, does it help coverage-guided fuzzers to know more about containerd, compared to launching containerd as an external process?
There was a problem hiding this comment.
Regarding directly instantiating fuzzers, does it help coverage-guided fuzzers to know more about containerd, compared to launching containerd as an external process?
Yes. Interacting with an executable is less effective than the approach of launcing command.App
| "github.com/containerd/containerd/pkg/registrar" | ||
|
|
||
| "github.com/containerd/containerd" | ||
| _ "github.com/containerd/containerd/cmd/containerd/builtins" |
There was a problem hiding this comment.
Because this is using builtins package, adding CRI into builtins makes a circular dependency between builtins and CRI, hence avoided.
|
needs rebase due to conflict |
|
one more rebase to pick up the fix for windows integration #7106 |
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM
I think we can init plugins and test it in out of cri package in the future.
7 participants
This PR is removing some hacks from contrib/fuzz/oss_fuzz_build.sh. Rewriting Go source code with regex is too error-prone.