Skip to content

Forward ctr snapshotter flags on Windows#7086

Merged
kevpar merged 1 commit intocontainerd:mainfrom
jterry75:main
Jun 21, 2022
Merged

Forward ctr snapshotter flags on Windows#7086
kevpar merged 1 commit intocontainerd:mainfrom
jterry75:main

Conversation

@jterry75
Copy link
Copy Markdown
Contributor

@jterry75 jterry75 commented Jun 21, 2022

Signed-off-by: Justin Terry [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 21, 2022

Hi @jterry75. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jterry75
Copy link
Copy Markdown
Contributor Author

jterry75 commented Jun 21, 2022

@dcantah - Now we can also one-off test your snapshot size code as well. Super helpful

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Jun 21, 2022

Oooooh sweet!

dcantah
dcantah approved these changes Jun 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@jterry75
Copy link
Copy Markdown
Contributor Author

jterry75 commented Jun 21, 2022

LGTM if CI is green

Is CI ever red for my code? 😆

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Jun 21, 2022

Touché 😌

kevpar
kevpar approved these changes Jun 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar kevpar merged commit 0fac756 into containerd:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@kevpar kevpar kevpar approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jterry75 @k8s-ci-robot @dcantah @dmcgowan @kevpar