Skip to content

Ensure Windows Periodic workflow errors out while still uploading results.#7085

Merged
estesp merged 2 commits intocontainerd:mainfrom
aznashwan:main
Jun 22, 2022
Merged

Ensure Windows Periodic workflow errors out while still uploading results.#7085
estesp merged 2 commits intocontainerd:mainfrom
aznashwan:main

Conversation

@aznashwan
Copy link
Copy Markdown
Contributor

This patch aims to ensure that any test failures in the Windows Periodic
workflow will lead to the workflow being marked as failed (red) while still
processing/uploading the JUnit result files to GCloud for them to show
up in testgrid.

…ults.

This patch aims to ensure that any test failures in the Windows Periodic
workflow will lead to the workflow being marked as failed (red) while still
processing/uploading the JUnit result files to GCloud for them to show
up in testgrid.

Signed-off-by: Nashwan Azhari <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Jun 21, 2022

This seems like it's doing a bit more than what the title leads on haha This looks like it's adding in new hyperv test runs. Edit: Looks like this was fixed 👍

@aznashwan
Copy link
Copy Markdown
Contributor Author

@dcantah good catch, I had accidentally made the PR from the GitHub UI from my main and pushed the Hyper-V workflow from #7025 to give it another test run.

I'll keep my main set to this until it merges, sorry for the confusion!

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a43dfdf into containerd:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants