ctr: add --hostname flag to create, run#7082
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Jun 21, 2022
Merged
Conversation
Signed-off-by: Samuel Karp <[email protected]>
AkihiroSuda
approved these changes
Jun 21, 2022
Contributor
|
I know Windows is the {insert here}..., but can we please try to build the muscle to think "is this linux/windows specific" or can it benefit both. |
Member
Author
|
@jterry75 I mostly did it this way since I don't currently have a Windows machine to test. I'm happy to open another PR adding it to Windows but until I get access to a machine I'd need someone else to test it for me. |
Contributor
|
All good, we dont have CI for ctr so its a best effort anyways. No worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote this to help test samuelkarp/runj@658737c; might be useful upstream for other testing as well.