Skip to content

Make CI Fuzz less noisy#7065

Merged
kzys merged 5 commits intocontainerd:mainfrom
kzys:fuzz-quiet
Jun 21, 2022
Merged

Make CI Fuzz less noisy#7065
kzys merged 5 commits intocontainerd:mainfrom
kzys:fuzz-quiet

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Jun 15, 2022

This PR makes CR Fuzz less noisy. The fuzzers in cncf-fuzzing are untouched yet. They will be merged later (see #7066).

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kzys
Copy link
Copy Markdown
Member Author

kzys commented Jun 15, 2022

@AdamKorcz Does it make sense to move https://github.com/cncf/cncf-fuzzing/blob/58a5397633815046cccfd2f2e4940e463b443b74/projects/containerd/remotes_docker_fuzzer.go from the repository to this repository? This one is really noisy and I want to change its logging level.

@AdamKorcz
Copy link
Copy Markdown
Contributor

AdamKorcz commented Jun 15, 2022

Looks great. We can increase the log level even further. The logs are not needed for the fuzzers when they run continuously.

@AdamKorcz
Copy link
Copy Markdown
Contributor

@kzys kzys force-pushed the fuzz-quiet branch 2 times, most recently from b944dd6 to 37429aa Compare June 15, 2022 22:40
@kzys kzys marked this pull request as ready for review June 16, 2022 01:39
@kzys kzys changed the title Make CI Fuzz quiet Make CI Fuzz less noisy Jun 16, 2022
@kzys kzys force-pushed the fuzz-quiet branch 3 times, most recently from 23c8921 to b06020d Compare June 16, 2022 05:23
kzys pushed a commit to kzys/cncf-fuzzing that referenced this pull request Jun 20, 2022
containerd/containerd#7065 will move the fuzzer
to the upstream.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys
Copy link
Copy Markdown
Member Author

kzys commented Jun 20, 2022

This one is ready for review.

The result of "Run Fuzzers" from this PR is still noisy but better than what we have in main.

https://github.com/containerd/containerd/runs/6971814391?check_suite_focus=true

@kzys
Copy link
Copy Markdown
Member Author

kzys commented Jun 20, 2022

@AdamKorcz @mxpv Can you take a look?

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz @mxpv Can you take a look?

LGTM, but as a suggestion, the log level can be upped to panic.

Kazuyoshi Kato added 5 commits June 20, 2022 23:34
Signed-off-by: Kazuyoshi Kato <[email protected]>
It is too noisy and not really useful if the input is random.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
This test is one of the noisiest and should be moved from
cncf/cncf-fuzzing first.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@kzys
Copy link
Copy Markdown
Member Author

kzys commented Jun 20, 2022

@AdamKorcz Changed in 50f1a4e and f91616e.

@kzys kzys merged commit 16992a4 into containerd:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants