Downgrade MinGW in Windows setup scripts.#7062
Conversation
After the switch to MinGW 11.2.0 in containerd#6888, the containerd client integration tests were crashing with an apparent memory allocation error as described in golang/go#46099. This patch reverts MinGW to 10.3.0 to bypass the issue. Signed-off-by: Nashwan Azhari <[email protected]>
|
Hi @aznashwan. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Full context: the crash we're seeing is consistent and can be seen in all Windows Periodic runs since #6888 merged. (the latest green column was from a test of this PR) The issue had eluded me while testing #6888 since I had intentionally unset the Google bucket creds so the artifact upload would get skipped in my run in order to not have any PS: switching from @dcantah @kzys @dmcgowan could one of you please have a look over this before the next scheduled Windows CI run tonight? |
Can we also fix this one? |
|
@kzys turns out the test command does correctly error out, and the actual culprit was the lack of Unfortunately it looks like MinGW needed an additional downgrade as well, which I've just shoehorned into that PR directly. |
For more context on the reason for the downgrade containerd/containerd#7062 Signed-off-by: Maksim An <[email protected]>
For more context on the reason for the downgrade containerd/containerd#7062 Signed-off-by: Maksim An <[email protected]>
For more context on the reason for the downgrade containerd/containerd#7062 Signed-off-by: Maksim An <[email protected]>
After the switch to MinGW 11.2.0 in #6888, the containerd client
integration tests were crashing with an apparent memory allocation
error as described in golang/go#46099.
This patch reverts MinGW to 10.3.0 to bypass the issue.
Signed-off-by: Nashwan Azhari [email protected]