Skip to content

Downgrade MinGW in Windows setup scripts.#7062

Merged
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:win-intergartion-downgrade-mingw
Jun 15, 2022
Merged

Downgrade MinGW in Windows setup scripts.#7062
kzys merged 1 commit intocontainerd:mainfrom
aznashwan:win-intergartion-downgrade-mingw

Conversation

@aznashwan
Copy link
Copy Markdown
Contributor

After the switch to MinGW 11.2.0 in #6888, the containerd client
integration tests were crashing with an apparent memory allocation
error as described in golang/go#46099.

This patch reverts MinGW to 10.3.0 to bypass the issue.

Signed-off-by: Nashwan Azhari [email protected]

After the switch to MinGW 11.2.0 in containerd#6888, the containerd client
integration tests were crashing with an apparent  memory allocation
error as described in golang/go#46099.

This patch reverts MinGW to 10.3.0 to bypass the issue.

Signed-off-by: Nashwan Azhari <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aznashwan
Copy link
Copy Markdown
Contributor Author

Full context: the crash we're seeing is consistent and can be seen in all Windows Periodic runs since #6888 merged. (the latest green column was from a test of this PR)

The issue had eluded me while testing #6888 since I had intentionally unset the Google bucket creds so the artifact upload would get skipped in my run in order to not have any junit files uploaded to the bucket, but the the actual test command never errors out, leading to the GitHub actions always being green.

PS: switching from mingw = "11.2.0" to mingw = "11.3.0" still shows the issue, so a downgrade is the only soluion at this point.

@dcantah @kzys @dmcgowan could one of you please have a look over this before the next scheduled Windows CI run tonight?

@kzys
Copy link
Copy Markdown
Member

kzys commented Jun 15, 2022

but the the actual test command never errors out, leading to the GitHub actions always being green.

Can we also fix this one?

@kzys kzys merged commit bc452f8 into containerd:main Jun 15, 2022
@aznashwan
Copy link
Copy Markdown
Contributor Author

aznashwan commented Jun 21, 2022

@kzys turns out the test command does correctly error out, and the actual culprit was the lack of pipefail in the Windows workflow itself, which I've addressed in #7085.

Unfortunately it looks like MinGW needed an additional downgrade as well, which I've just shoehorned into that PR directly.

anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Jun 23, 2022
For more context on the reason for the downgrade containerd/containerd#7062

Signed-off-by: Maksim An <[email protected]>
anmaxvl added a commit to microsoft/hcsshim that referenced this pull request Jun 24, 2022
For more context on the reason for the downgrade containerd/containerd#7062

Signed-off-by: Maksim An <[email protected]>
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Jul 11, 2022
For more context on the reason for the downgrade containerd/containerd#7062

Signed-off-by: Maksim An <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants