Improve naming consistencies in comments in snapshotter.go#7032
Improve naming consistencies in comments in snapshotter.go#7032kzys merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @swagatbora90. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
samuelkarp
left a comment
There was a problem hiding this comment.
Is there a particular reason you preferred upper-case for consistency rather than lower-case?
Mostly because majority of the existing comments are using upper-case and the usage seemed similar to how we refer a proper noun. |
Makes sense. My bias would be lower-case, but we don't have a style guide so this is fine too. (Since you're at Amazon: you can check around with the doc writers there but the AWS style guide generally prefers lower-case for object names.) Your fixup commit is causing CI to fail since it does not have a proper DCO signature. Mind squashing the commits together and making sure you retain the Signed-off-by line so that the CI workflow can continue? |
c4ccc27 to
02b85b9
Compare
Thanks for the review. I have not seen any such style guide myself, but I will look around. Perhaps it will have some good justification around the using lower case. |
mikebrow
left a comment
There was a problem hiding this comment.
prefer moving to and / or sticking with the lowercase, in this case
Signed-off-by: Swagat Bora <[email protected]>
02b85b9 to
61690d7
Compare
Sure, I have changed to use lower-case, since there is a clear preference now. PTAL. |
Signed-off-by: Swagat Bora [email protected]
snapshotter.gocomments to use uppercase in all places forthe Snapshotter