Hi @aznashwan. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

In its current stage, this is basically a duplicate of the Windows Integration workflow which instead pulls unmerged/unshipped versions of containerd/hcsshim to run the CRI test suite against containerd using Hyper-V Containers as described in #6862.

I'm wondering from the runs you sent me if we should skip the 4 or so tests that are exploding at the moment

Pingaroo. We still need to look into why the attach test case for CRI can hang for an hour on 2019, but should we skip the restart test that we know is flaky/doesn't work for hyp at the moment?

Pingaroo. We still need to look into why the attach test case for CRI can hang for an hour on 2019, but should we skip the restart test that we know is flaky/doesn't work for hyp at the moment?

Considering there are just a few tests that are failing, I'd say skip for now, and open a new issue to track them. We can start debugging each one.

Works for me, I'd love to get this checked in to start getting some data

I also opened this to hopefully be able to get in the small hcsshim changes needed to get rid of the need to use hcsshim master here (and the cherry-picks of the other hyp work here) #7138

@dcantah I'm currently doing a run with TestContainerdRestart skipped to ensure the rest of the RunCriIntegrationTests step finishes successfully.

LE: please ignore the below, I was under the incorrect impression that #6901 contained actual containerd-side config definitions which were required during testing instead of them only being internal defaults which get overridden anyway. I have switched the PR back to containerd/main.

> I also opened this #7138

That'd be great to replace the hardcoded tip of HCSSHIM we currently have going, but it wouldn't eliminate the need to hardcode a branch of containerd which features the config updates from #6901.

Note that the workflow is currently using a dedicated branch on my repo which I've kept rebasing over containerd/main, but I'd much prefer we host the config changes from #6901 on a branch on the main containerd/containerd repo.

Once (if) we do get a branch/tag to host the config changes on the main repo, I'll have to adapt the workflow to pull said branch and rebase it over main so we can test the latest code in main every night while still passing on the Hyper-V config.

@aznashwan We merged #7284 so you're good to use the commit in here now!

@dcantah just rebased and re-ran the workflow, and although there's two critest tests failing on both 2019 and 2022 (one a timeout while stopping a container we discussed a while back and another apparent port forwarding issue)

@kzys could you please have a look too?