Skip to content

Bump grpc to v1.47.0#7018

Merged
kzys merged 1 commit intocontainerd:mainfrom
lucacome:bump-grpc
Jun 6, 2022
Merged

Bump grpc to v1.47.0#7018
kzys merged 1 commit intocontainerd:mainfrom
lucacome:bump-grpc

Conversation

@lucacome
Copy link
Copy Markdown
Contributor

@lucacome lucacome commented Jun 2, 2022

Bumps grpc

@lucacome
Bump grpc to v1.47.0
5fcde82 
Signed-off-by: Luca Comellini <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 2, 2022

Hi @lucacome. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Jun 3, 2022

/ok-to-test

mikebrow
mikebrow approved these changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will you be pushing a PR on k8s.io? We generally try to keep in sync with kubernetes on the CRI api, but of late are getting a bit ahead.

kzys
kzys approved these changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Re-running the failed tests...

@kzys
Copy link
Copy Markdown
Member

kzys commented Jun 3, 2022

@lucacome

LGTM will you be pushing a PR on k8s.io? We generally try to keep in sync with kubernetes on the CRI api, but of late are getting a bit ahead.

Please ping us when you open the PR.

@lucacome
Copy link
Copy Markdown
Contributor Author

lucacome commented Jun 3, 2022

@kzys PR opened kubernetes/kubernetes#110378

mikebrow
mikebrow approved these changes Jun 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 8bf5995 into containerd:main Jun 6, 2022
@lucacome lucacome deleted the bump-grpc branch June 6, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucacome @k8s-ci-robot @mikebrow @kzys