Skip to content

Fix containerd-stress duration flag#7004

Merged
estesp merged 1 commit intocontainerd:mainfrom
SilverSoldier:patch-1
Jun 2, 2022
Merged

Fix containerd-stress duration flag#7004
estesp merged 1 commit intocontainerd:mainfrom
SilverSoldier:patch-1

Conversation

@SilverSoldier
Copy link
Copy Markdown
Contributor

The command for stressing containerd using containerd-stress, as specified in BUILDING.md, currently has -t 120 to run stress test for 2 hours. However, the actual command seems to require the duration to be specified using the -d flag.

Signed-off-by: SilverSoldier [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @SilverSoldier. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Note: we have a requirement for real name and email on commits

Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the real name requirement.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp dismissed mikebrow’s stale review June 2, 2022 07:37

contributor updated commit with name info

@estesp estesp merged commit 5e87626 into containerd:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants