Skip to content

Initial windows runtime work#700

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
mlaventure:rebased-windows
Apr 7, 2017
Merged

Initial windows runtime work#700
stevvooe merged 1 commit intocontainerd:masterfrom
mlaventure:rebased-windows

Conversation

@mlaventure
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure commented Apr 6, 2017 •
edited
Loading

Signed-off-by: Kenfe-Mickael Laventure [email protected]

--

example command in ctr:

  • using git bash
./bin/ctr.exe  --address \\\\.\\pipe\\containerd-containerd run --runtime windows --layers "C:\\ProgramData\\docker\\windowsfilter\\371a5f489e6eb487a66e97423de88e3482ede1b542529da9a590ea4a44ac8696" --layers "C:\\ProgramData\\docker\\windowsfilter\\0940fef74de9345acabac936949034afd43ccc449285661c86ebf5ecc21d41a7" --id myls16 powershell ls
  • in powershell
bin\ctr.exe  --address \\.\pipe\containerd-containerd run --runtime windows --layers C:\ProgramData\docker\windowsfilter\371a5f489e6eb487a66e97423de88e3482ede1b542529da9a590ea4a44ac8696" --layers "C:\ProgramData\docker\windowsfilter\0940fef74de9345acabac936949034afd43ccc449285661c86ebf5ecc21d41a7" -t --id myls16 powershell ls

@mlaventure mlaventure force-pushed the rebased-windows branch 4 times, most recently from d28426b to 4cde33a Compare April 6, 2017 19:08
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 6, 2017 •
edited
Loading

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files           5        5           
  Lines         687      687           
=======================================
  Hits          431      431           
  Misses        160      160           
  Partials       96       96
Impacted Files Coverage Δ
snapshot/overlay/overlay.go 60.12% <ø> (ø) ⬆️
snapshot/btrfs/btrfs.go 53.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c8c56...c5843b7. Read the comment docs.

@mlaventure
Copy link
Copy Markdown
Contributor Author

mlaventure commented Apr 6, 2017

Well, this is now incomplete since exec was added (#696) 😅

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Apr 6, 2017

@mlaventure i thought windows does not have exec?

@mlaventure mlaventure force-pushed the rebased-windows branch 4 times, most recently from 3a28f5f to e2875ed Compare April 6, 2017 22:10
@lowenna
Copy link
Copy Markdown

lowenna commented Apr 6, 2017

@crosbymichael Yup, it has since day 1...

@mlaventure mlaventure force-pushed the rebased-windows branch 2 times, most recently from 642f680 to 1aac191 Compare April 6, 2017 22:17
@mlaventure
Copy link
Copy Markdown
Contributor Author

mlaventure commented Apr 6, 2017

Added Execs

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Apr 7, 2017

LGTM

@stevvooe can you take a peek at the content store and snapshot changes? Mostly just enabling windows build for those.

@mlaventure
Initial windows runtime work
c5843b7 
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
@mlaventure mlaventure changed the title [WIP] Initial windows runtime work Initial windows runtime work Apr 7, 2017
@mlaventure
Copy link
Copy Markdown
Contributor Author

mlaventure commented Apr 7, 2017

Should be good for a start, we can iterate/clean further

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Apr 7, 2017

LGTM

@stevvooe stevvooe merged commit c1325a5 into containerd:master Apr 7, 2017
@mlaventure mlaventure mentioned this pull request Apr 7, 2017
Merged
@mlaventure mlaventure deleted the rebased-windows branch April 10, 2017 17:00
@thaJeztah thaJeztah mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mlaventure @codecov-io @crosbymichael @lowenna @stevvooe