Add validations for Windows HostProcess CRI configs#6996
Merged
kzys merged 1 commit intocontainerd:mainfrom Jun 1, 2022
Merged
Add validations for Windows HostProcess CRI configs#6996kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
Member
Author
Contributor
|
Related to kubernetes/kubernetes#110140 which fixes a bug in the kubelet where sometimes the pod can be created without the hostprocess field set when it should be. |
cpuguy83
approved these changes
May 28, 2022
samuelkarp
reviewed
May 28, 2022
Member
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
Looks fine, but one small suggestion.
HostProcess containers require every container in the pod to be a host process container and have the corresponding field set. The Kubelet usually enforces this so we'd error before even getting here but we recently found a bug in this logic so better to be safe than sorry. Signed-off-by: Daniel Canter <[email protected]>
samuelkarp
approved these changes
May 28, 2022
kzys
approved these changes
Jun 1, 2022
fuweid
added
the
cherry-picked/1.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HostProcess containers require every container in the pod to be a HostProcess container and have the corresponding security context field set. The Kubelet usually enforces this so we'd error before even getting here, but we recently found a bug in that logic so better to be safe than sorry.