[release/1.6] config: improve config v1 deprecation message#6980
Merged
estesp merged 1 commit intocontainerd:release/1.6from May 24, 2022
Merged
[release/1.6] config: improve config v1 deprecation message#6980estesp merged 1 commit intocontainerd:release/1.6from
estesp merged 1 commit intocontainerd:release/1.6from
Conversation
The previous wording was causing confusion. Fix moby/moby issue 43628 Signed-off-by: Akihiro Suda <[email protected]> (cherry picked from commit 739cb4c) Signed-off-by: Akihiro Suda <[email protected]>
fuweid
approved these changes
May 24, 2022
jterry75
reviewed
May 24, 2022
| version := c.GetVersion() | ||
| if version < 2 { | ||
| logrus.Warnf("deprecated version : `%d`, please switch to version `2`", version) | ||
| logrus.Warnf("containerd config version `%d` has been deprecated and will be removed in containerd v2.0, please switch to version `2`, "+ |
Contributor
There was a problem hiding this comment.
please switch to
configversion2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #6972 (clean)
The previous wording was causing confusion.
Fix moby/moby#43628