Skip to content

Fix broken oss-fuzz build#6975

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz3
May 24, 2022
Merged

Fix broken oss-fuzz build#6975
dmcgowan merged 1 commit intocontainerd:mainfrom
AdamKorcz:fuzz3

Conversation

@AdamKorcz
Copy link
Copy Markdown
Contributor

@AdamKorcz AdamKorcz commented May 23, 2022

Fixes build by using go 1.18 and using compile_native_go_fuzzer for the Go 1.18 fuzzer.

Signed-off-by: AdamKorcz [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 23, 2022

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdamKorcz
Copy link
Copy Markdown
Contributor Author

AdamKorcz commented May 23, 2022

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46357#c9

@AdamKorcz
Fix broken oss-fuzz build
8a3114b 
Signed-off-by: AdamKorcz <[email protected]>
estesp
estesp approved these changes May 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented May 24, 2022

Is this a temporary fix or will this script need to be updated to match golang updates?

@AdamKorcz
Copy link
Copy Markdown
Contributor Author

AdamKorcz commented May 24, 2022

This a temporary fix until OSS-Fuzz switches to Go 1.18 and adds end-to-end support for the native fuzzing engine: google/oss-fuzz#7600

@dmcgowan dmcgowan merged commit 11de19a into containerd:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AdamKorcz @k8s-ci-robot @dmcgowan @estesp