Skip to content

config: improve config v1 deprecation message#6972

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
AkihiroSuda:improve-config-toml-version-message
May 24, 2022
Merged

config: improve config v1 deprecation message#6972
dmcgowan merged 1 commit intocontainerd:mainfrom
AkihiroSuda:improve-config-toml-version-message

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

The previous wording was causing confusion.
Fix moby/moby#43628

The previous wording was causing confusion.
Fix moby/moby issue 43628

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 9ab02ad into containerd:main May 24, 2022
@AkihiroSuda AkihiroSuda added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch and removed cherry-pick/1.5.x labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning message says deprecated version : 1, please switch to version 2

4 participants